search

caleb531 / play-song

An Alfred workflow for quickly and easily playing music in the Apple Music app
MIT License
109 stars 9 forks source link

can't find songs, albums, artists (can only find playlists) #44

Closed nikitavoloboev closed 6 years ago

nikitavoloboev commented 8 years ago

Is there anything I can do to fix this?

caleb531 commented 8 years ago

Can you please be more specific? Do you mean to say that playartist, playalbum, etc. show no results, but playplaylist is? Could you please post a screenshot of what you are seeing?

Thanks, Caleb

nikitavoloboev commented 8 years ago

Yes you are right.

Here is an example : 2016-10-09 at 22 44

And the result :

2016-10-09 at 22 44

Nothing found, yet I have the song.

Thank you for any help.

caleb531 commented 8 years ago

What Play Song version are you using? And by your screenshot, it looks like you've renamed the playsong filter to ps, correct? And if so, what other changes have you made to your installed version of the workflow?

Thanks, Caleb

nikitavoloboev commented 8 years ago

I got the most recent version, from your releases on GitHub (4.2.1).

Haven't made any other changes I think aside from chasing the name for the trigger.

caleb531 commented 8 years ago

I see. I suspect that Play Song is throwing an error, considering that not even the "No Results Found" result is showing. Can you please open the Alfred debugger for Play Song and run the workflow again, posting any error messages in this issue?

Where to find debugger:
screen shot 2016-10-09 at 2 11 58 pm

nikitavoloboev commented 8 years ago

Here is the error I get when running play song :

2016-10-12 at 00 08

Other actions also send this error code.

caleb531 commented 8 years ago

Hmm, interesting. What versions of OS X and iTunes are you using?

nikitavoloboev commented 8 years ago

El Captain latest. Can't update to Sierra yet.

caleb531 commented 8 years ago

Great! And what about your iTunes version? :)

nikitavoloboev commented 8 years ago

Here it is : 2016-10-12 at 11 15

caleb531 commented 8 years ago

I see—how strange. Alright, I need your help with some testing so we can hunt down and destroy this bug once and for all.

Attached below is a ZIP file containing «an AppleScript compiled from a large chunk the Play Song source code. Please extract the ZIP file and open the script in the Script Editor app (it may open in Script Editor by default, otherwise it's in under /Applications/Utilities).

Test Everything.zip

For me, this code runs fine, and the script returns some songs. For you, you should receive the same error you saw in Alfred's Debugger panel. However, the Script Editor should highlight the line where that error occurred, and that is what I want you to post here (screenshot is preferable).

Please let me know what you find, or if you have any questions.

Thanks, Caleb

nikitavoloboev commented 8 years ago

2016-10-14 at 23 25

There you go :)

caleb531 commented 8 years ago

Oh, interesting. Can you please add the following line above that line like so?

log theSong
set songArtwork to data of (item 1 of songArtworks)

Then, run the entire script again and paste the log results here. The log output should be under the Log icon (third icon on bottom) > Messages:

screen shot 2016-10-14 at 2 28 00 pm

nikitavoloboev commented 8 years ago

2016-10-14 at 23 47

caleb531 commented 8 years ago

Hmm, now can you please change log theSong to log (kind of theSong)? Also, directly below that line, please add another line: log songArtworks. Post the results when you've done all that.

Thanks for your patience—I want to fix this bug at least as much as you do. :)

nikitavoloboev commented 8 years ago

2016-10-15 at 21 35

caleb531 commented 8 years ago

Alright, that wasn't quite as useful as I was hoping. Please change:

log (kind of theSong)

to:

log ((kind of theSong) as text)

and post the new log output. Thanks!

littleblue50 commented 8 years ago

Just letting you know I'm also having this exact problem

caleb531 commented 8 years ago

@littleblue50, good to know. @nikitavoloboev, I haven't heard from you in a little over a month, but I still need your help testing this issue. Please respond when you can once you've tested the above. :)

Thanks, Caleb

littleblue50 commented 8 years ago

If it helps though, when I run your test script I don't get an error, I just get:

"{\"items\": [{\"uid\":\"no-results\",\"arg\":\"no-results\",\"valid\":\"no\",\"title\":\"No Results Found\",\"subtitle\":\"No songs matching 'Link'\",\"icon\":{\"path\":\"resources/icon-noartwork.png\"}}]}"

caleb531 commented 8 years ago

@littleblue50: interesting, though if you're not receiving the same error as @nikitavoloboev, then your problem is probably worthy of a separate GitHub issue.

caleb531 commented 6 years ago

@nikitavoloboev and @littleblue50,

I have just released Play Song v5, which includes a bug fix that may resolve this error. Could you both please download and test it to see if anything has improved for you?

Click to download Play Song v5

Thanks, Caleb

caleb531 commented 6 years ago

@nikitavoloboev and @littleblue50: I'm closing this issue because my testing has shown this issue is fixed by my patch above. If you are still experiencing problems, please let me know and I will reopen.