search

caleb98 / QuickSound

An addon for World of Warcraft that adds a hoverable sound panel for quickly adjusting game volumes.
0 stars 0 forks source link

DataBroker #1

Open TylerR909 opened 1 year ago

TylerR909 commented 1 year ago

Hiya, there seems to be a hole in the market for a functional DataBroker Volume plugin. QuickSound looks about perfect to fill that hole. Please consider looking into adding DataBroker support for this. https://github.com/tekkub/libdatabroker-1-1/wiki/api

A couple years ago my preferred addon broke and Volumizer became my go-to, but it seems to have met a similar fate.

Been a long time since I worked on my now-defunct addon but as I recall, actually writing a DataBroker is super simple: https://github.com/TylerR909/Talented/blob/master/TalentedLDB.lua

caleb98 commented 1 year ago

Hey Tyler! Thanks for bringing this to my attention!

I haven't personally had any experience with DataBroker or used any addons that take this plugin-display approach, so I'll admit that even after reading through the DataBroker wiki I'm still a little lost as to what kind of benefits it brings. That being said, it's definitely something I can look into if it seems like there would be a tangible improvement from adding the support.

I can't guarantee I'll get around to it quickly given that Dragonflight just released, but once things calm down I'll try to learn a bit more and take a closer look.

TylerR909 commented 1 year ago

Totally fair. Lots of addons provide "data brokers" for other addons to display. If you use Chocolatebar, or have heard of TitanPanel or FuBar from ages ago, those are all Data Broker "Displays." Also ElvUI's DataTexts (Below the left/right panels, the 2 on the minimap, or any more you add).

Not sure if you saw this page: https://github.com/tekkub/libdatabroker-1-1/wiki/How-to-provide-a-dataobject

Also it wouldn't be a bad idea to grab that Volumizer addon I linked and see how they did it 🙂