Open calebchris000 opened 1 year ago
Hi @calebchris000,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Title: [2pt] Authentication
Description: The user logs in to the website, only by typing the username (a proper authenticated login is a requirement if your group is made of 5 people).
That way, you'll have all your descriptions, and your titles more consistent. 👍
Remember, the descriptions field HAS to be filled for each card even if you don't take this suggestion.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@Meltrust Done. Thanks
Hi @dheerajsachdeva
Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Kindly, add that description and the project will be ready. 💪
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @Meltrust, Thanks a lot for pointing it out. I have resolved that, as well as any potential empty descriptions.
Cheers.
Hi @calebchris000 ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
The link to the Rails Repository
NOTE
We are 4 in the team.
Peace. ✌️