arslanbisharat
commented
1 year ago Hi @Lornakaboro, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Highlights
- The Pull Request has a proper title and description. ✔️
- You have added a descriptive Readme file. Good Job. ✔️
- There is no linter error is present. ✔️
- Project has met all the technical aspects you needed for this project. Keep rocking! ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this activity we did the following ;
Login page and registration page: We built the Login page and registration page with Devise.
We displayed a list of food added by the logged-in user as in the wireframe (also displayed the quantity of a given food). We created a form that allowed users to add new food.
We displayed a list of recipes created by the logged-in user as in the wireframe. We allowed users to view recipe details. For the owner of the recipe, we implemented the functionality to delete a recipe.
We displayed a list of all public recipes ordered by newest as in the wireframe. Users could view recipe details for each public recipe.
We implemented a toggle button that allowed users to make a recipe public or private. For public recipes or if the user was the owner of the recipe, we displayed the recipe details as in the wireframe. If the user was the owner of the recipe, we provided access to the form that allowed adding new food to the recipe.
We showed the list of food missing for all recipes of the logged-in user (compared the list of food for all recipes with the general food list of that user). We counted the total food items and total price of the missing food. We ensured no N+1 queries were happening.
Wrote unit and integration tests to ensure the functionality of the application.
We implemented a modal to choose an inventory to create a shopping list, as in the wireframe.
We showed the list of food missing by comparing the food in the recipe with the food in the inventory. We counted the total food items and total price of the missing food.
Technical setup:
We set up the repository on GitHub and used Gitflow for version control.
We set up Devise for authentication.
We integrated RSpec and Capybara testing libraries to facilitate testing and ensure the reliability of the codebase.