search

calebd / SimpleAuth

Simple social authentication for iOS.
http://simpleauth.io
MIT License
1.15k stars 135 forks source link

SimpleAuthTwitterProvider not showing UIActionSheet on iPad2 iOS 8.1 #77

Open MaximKeegan opened 10 years ago

MaximKeegan commented 10 years ago 
- (void)presentActionSheet:(UIActionSheet *)actionSheet {
    UIWindow *window = [UIWindow SimpleAuth_mainWindow];
    [actionSheet showInView:window];
}

Not working on iOS8. It doesn't work because Apple changed internal implementation of UIActionSheet. Can you please use UIAlertController with a preferredStyle of UIAlertControllerStyleActionSheet?

calebd commented 10 years ago

Shouldn't showInView: still work? I don't want to move to UIAlertcontroller just yet since that I'd have to require iOS 8.

MaximKeegan commented 10 years ago

I have tested showInView: on iPad iOS8.1 and it didn't work. Does not show UIActionSheet at all. But on iPhone it works well. You can see #79. I have made hotfix for my app.

dkhamsing commented 9 years ago

Can this be closed?

calebd commented 9 years ago

@dkhamsing Maybe? I think I would rather deprecate using sheets for this (since they got weird in 8) and switch to a view controller. What do you think about that?

dkhamsing commented 9 years ago

Ah I see.. yeah makes sense