Lodin commented 3 years ago

Adds a detection and correction for Safari broken rules mentioned in #84.

Lodin commented 3 years ago

@calebdwilliams, could you please test this solution? Since I'm a Windows user, testing on Mac is pretty inconvenient for me. I'm concerned about if it correctly detects Safari browser and how many cases are supported correctly.

Lodin commented 3 years ago

Hmm, maybe I have an idea of a better solution...

calebdwilliams commented 3 years ago

@Lodin keep me posted

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ded7a2e). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage        ?   92.89%           
=======================================
  Files           ?        6           
  Lines           ?      211           
  Branches        ?       36           
=======================================
  Hits            ?      196           
  Misses          ?        4           
  Partials        ?       11

Flag	Coverage Δ
unittests	`92.89% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ded7a2e...3625ec2. Read the comment docs.

Lodin commented 3 years ago

@calebdwilliams, I believe I finished the fix. Please test it with the Safari a bit more, because it might be that I haven't considered all the possible cases here.

Lodin commented 3 years ago

@calebdwilliams, do not mind my changes after the previous comment. That's mostly cosmetic optimizations. Please review and merge whenever you want.

calebdwilliams / construct-style-sheets

Fix Safari broken rules #86

Codecov Report