search

calebhearth / formulaic

Simplify form filling with Capybara
MIT License
552 stars 29 forks source link

Fallback to `select` if array of `checkboxes` fail #34

Closed seanpdoyle closed 10 years ago

seanpdoyle commented 10 years ago

Allows fields that are arrays of strings to be passed to <select multiple> inputs.

calebhearth commented 10 years ago

Pushed up ugly but working code. It could benefit from some extract method.

calebhearth commented 10 years ago

Your failing test is in a branch at sd-select-array-failing

seanpdoyle commented 10 years ago

Nice work, I'll take a look tomorrow

seanpdoyle commented 10 years ago

Right, I plan on squashing and authoring a good commit message before this gets merged.

seanpdoyle commented 10 years ago

@calebthompson ok squashed my commit and split out the files.

What else is blocking this?

calebhearth commented 10 years ago

LGTM.

seanpdoyle commented 10 years ago

Should these commits get squashed to 1 or are you ok with them as-is?

calebhearth commented 10 years ago

Not much of a story being told, I think. Go ahead and squash them.