Closed svmnotn closed 7 years ago
I've made some pretty big changes. Mind doing a review?
Notable changes:
Box
.I should probably add that before this gets merged I want unit tests for all the things and integration tests on the binary.
@calebmer review over, please check the comments and try to see if box as truly unnecessary, I think you will see it was not.
Yeah, I had a wrastle with Box
when trying to update errors. For the current code it isn't necessary so I didn't include it, but it will be necessary in the future. But even then when trying to put out that fire I also saw &
and maybe *
as a way to alleviate the problem with a more compact and potentially idiomatic way to specify a pointer.