Add postgres driver to accelerate

calebmer / accelerate

Accelerate back and forth through time for your database or other in-place systems

MIT License

5 stars 0 forks source link

Add postgres driver to accelerate #9

Closed svmnotn closed 7 years ago

svmnotn commented 8 years ago

[x] Get things to compile.
[ ] Complete all functionality that existed in the JS version of the driver.
[ ] Make tests to make sure everything works.
[ ] Clean up the code.

calebmer commented 8 years ago

I've made some pretty big changes. Mind doing a review?

calebmer commented 8 years ago

Notable changes:

Created a Makefile for build process vs random bash scripts.
Moved accelerator unit tests inline (as is idiomatic rust).
Merged the accelerator functions into the driver trait.
Removed the need for Box.

calebmer commented 8 years ago

I should probably add that before this gets merged I want unit tests for all the things and integration tests on the binary.

svmnotn commented 8 years ago

@calebmer review over, please check the comments and try to see if box as truly unnecessary, I think you will see it was not.

calebmer commented 8 years ago

Yeah, I had a wrastle with Box when trying to update errors. For the current code it isn't necessary so I didn't include it, but it will be necessary in the future. But even then when trying to put out that fire I also saw & and maybe * as a way to alleviate the problem with a more compact and potentially idiomatic way to specify a pointer.