"Back button" on group page does "nothing" on mobile

calebmer / connect

10 stars 2 forks source link

"Back button" on group page does "nothing" on mobile #73

Closed brenthaertlein closed 5 years ago

brenthaertlein commented 5 years ago

The "back" button in the upper left hand corner of the screen has no effect when pressed on Mobile at the "Conversation Feed" view.

Browser: Chrome 74.0.3729.112 OS: Android 8.0.0, SM-J737A Build/R16NW

Screenshot_20190530-193513_Chrome

calebmer commented 5 years ago

Ah, it should do a browser history “pop” taking you back to the previous page. That’s because I assumed the previous page would be https://connect.ink/account which is obviously not true if you navigate directly to the URL 😛

calebmer commented 5 years ago

What it should do on web is push https://connect.ink/account. On native it should still pop for animation and spatial reasoning purposes. Also because we have total control over the navigation stack on iOS/Android.

calebmer commented 5 years ago

Fixed: https://github.com/calebmer/connect/commit/c4edd3227281be5e188ca22873ce8c132e8c1ec6