calebmeyer / vim-mode-plus-macros

Adds macros for vim mode plus
12 stars 2 forks source link

Two small features added #9

Open sebiik opened 4 years ago

sebiik commented 4 years ago

Hi Caleb, thank you for your package, I use it frequently. I'm simply using a pull request here just to send you this message, so no worries if you don't merge or even look at my changes.

As to the changes I made:

  1. I've added a safety exit when you try to apply a macro while still in recording mode. It will simply not apply anything and take you out of recording mode first (as I feel that once you forget to leave recording mode your macro is unusable anyway and you'll have to start over).

  2. I've felt that an append function would be neat. There are two versions as I felt some people will want a pure append mode like in Vim (Q), but that may become confusing because it lets you add your moves with no regard to what the current macro does. So I've added 'apply then append' mode (g @) which may be more intuitive for some as you can run your macro, see what it did, then add your changes from there.

I'm not a pro coder so if you feel that I wrote some bad code or messed up yours I apologize in advance!

Thank you again for this package, Seb