search

calebolson123 / BabySleepCoach

DIY Baby Sleep Tracking
https://calebolson.com
Other
201 stars 35 forks source link

Refactor of the code #6

Open nos86 opened 1 year ago

nos86 commented 1 year ago

Refact the code in different files.

calebolson123 commented 1 year ago

nitpick: I haven't combed through all the changes yet, but just testing it locally, looks like the styling is off for the bar. imo text & bar shouldn't overlap

image

calebolson123 commented 1 year ago

I was able to get it to run locally. But with a clip where the system should easily detect sleeping, it's not. Have you seen it detect sleeping yet on your end?

nos86 commented 1 year ago

nitpick: I haven't combed through all the changes yet, but just testing it locally, looks like the styling is off for the bar. imo text & bar shouldn't overlap

image

this has been solved with last commits. I simplified the code and put all parameters in function signature for a easier customization of other users.

nos86 commented 1 year ago

I added code to implement python-fire as CLI. I this point in time, I'd like to stop implementing new feature and I want to consolidate these changes. After that I will restore existing feature that I have commented at the beginning of my work.

Please for testing purpose use following command line: python main.py -v --log_on_screen live streaming_url for streaming and python main.py -v --log_on_screen recorded video.mp4 for recorded video

You can use the help command as well: python main.py -h and python main.py live -h

calebolson123 commented 1 year ago

I this point in time, I'd like to stop implementing new feature and I want to consolidate these changes. After that I will restore existing feature that I have commented at the beginning of my work.

Ah, tiny modification w/ the -, works now. python main.py -v --log_on_screen - live Nice, cool to see python-fire in action.

"existing feature that I have commented at the beginning of my work" - what are you referencing here?