search

calebsmith / django-template-debug

A small collection of template tags for debugging and introspecting templates
BSD 3-Clause "New" or "Revised" License
74 stars 11 forks source link

Import pdb/ipdb (late, only when used) in `set_trace` #22

Closed blueyed closed 10 years ago

blueyed commented 10 years ago

Fixes https://github.com/calebsmith/django-template-debug/issues/21

calebsmith commented 10 years ago

Apologies it took a couple of days to review this. I see the clear benefit in doing the import this way and thank you for contributing.

I know I failed to have a contributors guide, but could you redo the PR against develop instead? I like to keep master void of changes until a new release is coming.

Also, you can add yourself to the AUTHORS file if you don't mind. Otherwise I'll do it at some point later.

Thanks again for the contribution.

blueyed commented 10 years ago

I have added myself to AUTHORS.

As for the PR: develop and master are the same currently, so you could just merge it into develop. If you want to merge it via Github's web interface, I would have to create a new one probably - let me know if I should do that.

btw: I highly recommend hub for extending git on the command line with Github features: https://hub.github.com/ Using hub, you could just do:

% git checkout develop
% git am -3 https://github.com/calebsmith/django-template-debug/pull/22
% git push origin develop
calebsmith commented 10 years ago

Awesome, thanks for adding yourself. I was initially underwhelmed by hub, but it has improved a lot since then. The method you described is pretty nice and easy, so I think you've convinced me to dig it up again.

I've merged your changes into master. Since I didn't click the green button I'll close the PR.

Thanks again for the contribution.