[FIXED #156] Raised exception on using 'sessions' - Githubissues

calebstewart / pwncat

Fancy reverse and bind shell handler

https://pwncat.readthedocs.io

MIT License

2.63k stars 258 forks source link

[FIXED #156] Raised exception on using 'sessions' #158

Closed Mitul16 closed 3 years ago

Mitul16 commented 3 years ago

Description of Changes

Fixes #156 There was a flake8 warning about an unused import, see https://github.com/Mitul16/pwncat/commit/a4cee5be27427d528b8a3e849f83c020dae6945b

Sorry for closing my last PR, there was one incorrect commit and some redundant commits added later. I wanted to keep it all clean :sweat_smile:

There is just one difference in this PR, see https://github.com/Mitul16/pwncat/commit/b511a37f71e7c8f722b70ab3d030d7c70d7f8c7d I have changed the error messages in pwncat/channel/connect.py so that they show the correct message.

Major Changes Implemented:

Fixed a possible exception due to pre-registering of session with manager
Added alternatives to bash to be used during shell upgrade for a better shell
Added a warning message when a KeyboardInterrupt is caught
Changed some 'red' warning message color to 'yellow'

Pre-Merge Tasks

[x] Formatted all modified files w/ python-black
[x] Sorted imports for modified files w/ isort
[x] Ran flake8 on repo, and fixed any new problems w/ modified files
[x] Ran pytest test cases
[x] Added brief summary of updates to CHANGELOG (under [Unreleased])

Mitul16 commented 3 years ago

Here is the commit 97cf14d314e58f56d83daa48744c045d2530adcf that added import signal to pwncat/platform/windows.py And here is the commit a95f2df50c3009f8584ceec6ebfaa93f55f22ed9 which made it an unused import.