Fixes #245 and minor patches

Mitul16 commented 2 years ago

Description of Changes

Fixes #245, it was merely a use of non-str type objects in the args list. I have type-casted them with str(...). There were a few minor issues, as discussed :sweat_smile: in https://github.com/calebstewart/pwncat/discussions/200

Major Changes Implemented:

fixed shlex.join use with non-str type objects (e.g. RemotePath)
fixed set command use with incorrect keys (e.g. set invalid value)
catch missed PlatformError for upload command

Pre-Merge Tasks

[x] Formatted all modified files w/ python-black
[x] Sorted imports for modified files w/ isort
[x] Ran flake8 on repo, and fixed any new problems w/ modified files
[x] Ran pytest test cases
[x] Added brief summary of updates to CHANGELOG (under [Unreleased])

EDIT: These changes fixes little issues so I am targetting master

Mitul16 commented 2 years ago

I have used black, isort, flake8 within the project directory, if you want my changes for the Pre-merge tasks to be restricted to the modified files only; let me know. I will revert those extra changes and only keep the changes for ./pwncat/pwncat directory for the modified files.

calebstewart commented 2 years ago

Regarding the isort/black changes made across other files, it's fine. I'm not sure how those oddities slipped through the cracks from previous merges, but it's fine that they're fixed here.

Regarding the fix(es), this looks great to me. I appreciate the help as always!

calebstewart / pwncat