[app_unimrcp] Support for compiling with Asterisk 1.2

[GoogleCodeExporter]

Working on testing Asterisk UniMRCP connector with Speechpro MRCPv1 server I 
ahve a task to make MRCP module work with Asterisk 1.2. This patch make 
possible compiling and use module with Asterisk 1.2.

Original issue reported on code.google.com by igor.gon...@gmail.com on 6 Feb 2010 at 1:37

Attachments:

• app_unimrcp_12.diff

[GoogleCodeExporter]

Igor, thanks for the patch submission.
I've basically reviewed it. Everything seems clear, though I have no Asterisk 
1.2 to
try it out, at least it's compilable on my Asterisk 1.6.

Derik, I leave final acceptance after you. Please review the patch when 
possible.

Thanks.

Original comment by achalo...@gmail.com on 6 Feb 2010 at 5:41

• Added labels: Component-Asterisk, OpSys-Linux, Priority-Medium, Type-Patch

[GoogleCodeExporter]

Hi Igor & Arsen,

Thanks. I'm busy checking out the Asterisk sources and will compile/test 
shortly.

Kind regards,
Derik

Original comment by thirion...@gmail.com on 6 Feb 2010 at 7:32

• Changed state: Started

[GoogleCodeExporter]

Hi Derik,

I think we can rely on Igor concerning Asterisk 1.2 compliance. Probably you 
should
just basically check the supported versions are still compilable.
Anyway, it's up to you.

Thanks.

Original comment by achalo...@gmail.com on 6 Feb 2010 at 7:47

[GoogleCodeExporter]

Dear Arsen,

I agree, but checking the build of the entire project, presented some problems.

I've compiled the asterisk-unimrcp project successfully against Asterisk 
versions 
1.6.0.22, 1.6.1.14, 1.6.2.2 and trunk.

For Asterisk 1.2.37, the res_speech_unimrcp build fails totally, but 
app_unimrcp 
does compile. I suppose we need some sort of a conditional check in Makefile.am 
to 
change SUBDIRS to "app-unimrcp" instead of "res-speech-unimrcp app-unimrcp" for 
Asterisk versions below 1.4.

Also, for Asterisk version 1.4.29, which was able to compile res_speech_unimrcp 
previously (I think before revision 1434), now doesn't copile 
res_speech_unimrcp.

res_speech_unimrcp.c:944: warning: initialization from incompatible pointer type
res_speech_unimrcp.c: In function 'uni_engine_config_load':
res_speech_unimrcp.c:1004: error: too many arguments to function 
'ast_config_load'

it looks like it is due to the following line added in revision 1436 
res_speech_unimrcp.c in the :
struct ast_config *cfg = ast_config_load(UNI_ENGINE_CONFIG, config_flags);

http://code.google.com/p/unimrcp/source/diff?
spec=svn1436&r=1436&format=side&path=/solutions/asterisk-unimrcp/res-speech-
unimrcp/res_speech_unimrcp.c

Perhaps we can have a version 1.4 compatability #ifdef for res_speech_unimrcp? 
Revision 1434 worked fine, but 1436 doesn't with Asterisk 1.4.29.

I've checked in Igor's changes.

Kind regards,
Derik

Original comment by thirion...@gmail.com on 6 Feb 2010 at 9:24

• Changed state: Fixed

[GoogleCodeExporter]

Hi Derik,

Great and fast response and comprehensive analyzes!

I've added an option to explicitly enable/disable one of the modules if/when 
needed
in r1462.
./configure --disable-res-speech-unimrcp
or
./configure --disable-app-unimrcp

Also, I agree that res-speech-unimrcp should be implicitly disabled for 
Asterisk 1.2.
I've added it in 1469.

I hoped to look into the issue related to compilation of res-speech-unimrcp for
Asterisk 1.4, but it's not for today :)

Thnaks.

Original comment by achalo...@gmail.com on 7 Feb 2010 at 5:57

[GoogleCodeExporter]

Original comment by thirion...@gmail.com on 10 Mar 2010 at 11:00

• Changed state: Verified