calejost / unimrcp

Automatically exported from code.google.com/p/unimrcp
Apache License 2.0
0 stars 0 forks source link

Access violation while reading server config #66

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi Arsen,

when you reworked server configuration, you forgot to change one attribute
into an element. Actually it looks like a typo. Everything is clear from
the diff:

Index: unimrcp_server.c
===================================================================
--- unimrcp_server.c    (revision 1478)
+++ unimrcp_server.c    (working copy)
@@ -608,7 +608,7 @@
        apt_log(APT_LOG_MARK,APT_PRIO_DEBUG,"Loading Engine Params");
        config->params = apr_table_make(loader->pool,1);
        for(elem = root->first_child; elem; elem = elem->next) {
-           if(strcasecmp(attr->name,"max-channel-count") == 0) {
+           if(strcasecmp(elem->name,"max-channel-count") == 0) {
                if(is_cdata_valid(elem) == TRUE) {
                    config->max_channel_count = atol(cdata_text_get(elem));
                }

Cheers
- Vali

PS. I noticed a windows-specific path delimiter in client configuration
profiles:
    xsi:noNamespaceSchemaLocation="..\unimrcpclient.xsd" 
Do not you think it should be replaced with XML-preferred forward-slash,
which also works fine in Visual Studio?

Original issue reported on code.google.com by tomas.valenta@speechtech.cz on 8 Feb 2010 at 10:20

GoogleCodeExporter commented 8 years ago
Hi Vali,

Fixed in r1474.

Thanks,
Arsen

P.S. Feel free to commit such fixes directly to the repository if needed.

Original comment by achalo...@gmail.com on 9 Feb 2010 at 5:47

GoogleCodeExporter commented 8 years ago
Okay, next time I will commit such simple fixes myself, thanks for the trust.

What do you think about the backslash in the path to the XML schema?

Original comment by tomas.valenta@speechtech.cz on 10 Feb 2010 at 8:05

GoogleCodeExporter commented 8 years ago
Yes, I trust you.

I'm not sure which backslash you mean. Please clarify.

Original comment by achalo...@gmail.com on 10 Feb 2010 at 8:31

GoogleCodeExporter commented 8 years ago
In client configuration profiles (e.g. conf/client-profiles/unimrcp.xml) in the 
root
element attribute there is a link to the schema:

<unimrcpclient xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
               xsi:noNamespaceSchemaLocation="..\unimrcpclient.xsd" 
               version="1.0">

I would replace it with "../unimrcpclient.xsd" which is preferred in XML and 
works
fine in Visual Studio.

Original comment by tomas.valenta@speechtech.cz on 10 Feb 2010 at 8:47

GoogleCodeExporter commented 8 years ago
Well, makes sense. Fixed in r1489

Original comment by achalo...@gmail.com on 11 Feb 2010 at 6:31

GoogleCodeExporter commented 8 years ago
Thanks.

Original comment by tomas.valenta@speechtech.cz on 11 Feb 2010 at 9:54