search

calejost / unimrcp

Automatically exported from code.google.com/p/unimrcp
Apache License 2.0
0 stars 0 forks source link

[patch] APR pools thread safety patch for APR 1.3.9 #69

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi there,

This is the patch to fix issue 29, when using APR 1.3.9. I basically
followed the changes made for APR 1.3.6 at:
http://www.unimrcp.org/dependencies/p1-apr-pools.diff?attredirects=0&d=1

and modified the corresponding lines in the files listed in the diff.

Kind regards,
Derik Thirion

Original issue reported on code.google.com by thirion...@gmail.com on 16 Feb 2010 at 7:52

Attachments:

GoogleCodeExporter commented 8 years ago 
I have also checked it against the dependency package for UniMRCP 0.9.0 that was
released with APR 1.3.8 
(http://unimrcp.googlecode.com/files/unimrcp-deps-0.9.0.tar.gz).

Original comment by thirion...@gmail.com on 16 Feb 2010 at 7:59

GoogleCodeExporter commented 8 years ago 
Here are the corresponding patched archives for your convenience.

Original comment by thirion...@gmail.com on 16 Feb 2010 at 8:14

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi Derik,

Thanks for the patch submission.

As far as I remember APR 1.3.9 has introduced a regression, can't recall what 
it's
exactly. Perhaps, UniMRCP isn't affected.
BTW, APR 1.3.12 is under the way and I consider using it with the next version 
of
UniMRCP. Time will show. The voting is still in-progress. 
http://mail-archives.apache.org/mod_mbox/apr-dev/201002.mbox/browser
[VOTE] release apr-1.3.12

Anyway, your patch is welcome and helpful too.

Original comment by achalo...@gmail.com on 16 Feb 2010 at 8:17

GoogleCodeExporter commented 8 years ago 
Thanks. Have you considered using 1.4.2? Seems like there were some important 
changes:

Changes for APR 1.4.2

  *) Undo a crash-bug introduced in 1.3.9 affecting some applications of 
     the apr hash and table structures, reported to affect Subversion
     by Bert Huijben <bert qqmail.nl>.  [Graham Leggett]

Original comment by thirion...@gmail.com on 16 Feb 2010 at 10:53

GoogleCodeExporter commented 8 years ago 
Not yet. BTW, that crash-bug seems to be introduced only in 1.4.x

http://mail-archives.apache.org/mod_mbox/apr-dev/201001.mbox/browser

Original comment by achalo...@gmail.com on 16 Feb 2010 at 11:18

GoogleCodeExporter commented 8 years ago 
Here are the 1.3.12 versions. Enjoy!

Original comment by thirion...@gmail.com on 16 Feb 2010 at 11:20

Attachments:

GoogleCodeExporter commented 8 years ago 
Great! Will do.

Original comment by achalo...@gmail.com on 16 Feb 2010 at 11:24

GoogleCodeExporter commented 8 years ago

Original comment by thirion...@gmail.com on 16 Feb 2010 at 11:41

GoogleCodeExporter commented 8 years ago

Original comment by thirion...@gmail.com on 10 Mar 2010 at 11:00

GoogleCodeExporter commented 8 years ago 
Hi Derik,

I waited for the official release of APR-1.3.12 to bundle it with UniMRCP 
0.10.0, but
as of today they haven't released it yet. So I'll leave this for the next 
release as
it's not possible to wait any more.
Anyway, I just would like to thank you again for everything you have made!

Original comment by achalo...@gmail.com on 10 Mar 2010 at 11:14

GoogleCodeExporter commented 8 years ago 
Hi Arsen,

Thanks for the kind words.

I am doubting whether 1.2.12 is such a good idea. I'm using log4cxx in my 
projects as
well, and there seems to be issues with 1.2.12. Not sure exactly what, but 
here's an
interesting link:

http://www.elpauer.org/?p=250

For now, I'm using APR 1.3.8 and APR-Util 1.3.9 with great success.

Kind regards,
Derik

Original comment by thirion...@gmail.com on 10 Mar 2010 at 12:16

GoogleCodeExporter commented 8 years ago 
Hi Derik,

I remember we used 1.2.8 and 1.2.12 versions quite a lot in the past. However, 
please
note those are 1.2.x versions. The version, which is due to be released is 
1.3.12 :)
Perhaps, I'm fine using current dependency package either.

Best regards,
Arsen

Original comment by achalo...@gmail.com on 10 Mar 2010 at 12:28

GoogleCodeExporter commented 8 years ago 
Got you. Sorry about that. Just too fast on the reading... Suppose that's the 
problem
with being under too much load... :-)

Original comment by thirion...@gmail.com on 10 Mar 2010 at 1:58