calf-studio-gear / calf

Developers repository of Calf Studio Gear. Expect some issues when using it for production.
http://calf-studio-gear.org
GNU Lesser General Public License v2.1
685 stars 95 forks source link

Calf Fluidsynth LV2 - pitch bend only works when on MIDI channel 1 #77

Open ghost opened 8 years ago

ghost commented 8 years ago

I'm using Calf Fluidsynth as an LV2 plugin in Qtractor and it seems that pitch bend doesn't respond unless the track's MIDI channel is set to 1. On any other channel, pitch bend is ignored, though Controller events (e.g. Controllers 7 and 11) seem fine. FYI, Fluidsynth DSSI responds to pitch bend whatever the channel.

I spoke to Rui and he thinks this might be a Calf issue, as Fluidsynth DSSI and his vee-one plugins are OK. Please see here.

I've tried a recent Calf stable release and the latest git. Both were the same.

Iansamit commented 7 years ago

Thanks - you got me out of a jam!

I can confirm this issue.

sohet commented 4 years ago

As reported to Debian BTS #970631, I think the bug can be fixed easily.

--- src/calf/modules_dev.h.orig 2019-07-17 01:57:45.000000000 +0900
+++ src/calf/modules_dev.h  2020-09-20 20:09:53.000000000 +0900
@@ -78,7 +78,7 @@
     /// Handle pitch bend message.
     inline void pitch_bend(int channel, int value)
     {
-        fluid_synth_pitch_bend(synth, 0, value + 0x2000);
+        fluid_synth_pitch_bend(synth, channel, value + 0x2000);
     }
     /// Handle control change messages.
     void control_change(int channel, int controller, int value);
ShalokShalom commented 3 months ago

Can this still be reproduced?