search

calfarog / GREENeR

Geospatial Regression Equation for European Nutrient losses (GREEN)
https://calfarog.github.io/GREENeR/articles/GREENeR.html
GNU General Public License v3.0
1 stars 0 forks source link

Missing Suggests: codetools (a recommended package) #1

Open HenrikBengtsson opened 2 years ago

HenrikBengtsson commented 2 years ago

Hi.

tl:dr, please add:

Suggests: codetools

I'm running reverse dependencies checks on my parallelly package, and I do it in a setup without "recommended" package installed, which are technically optional. In this setup, I got (https://github.com/HenrikBengtsson/parallelly/blob/9374fe449f354fad54a41169799ee2ff12d1425f/revdep/problems.md#greener):

Error(s) in re-building vignettes:
--- re-building ‘GREENeR.Rmd’ using rmarkdown
code for methods in class "Rcpp_SpatCategories" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatCategories" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatDataFrame" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatDataFrame" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatExtent" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatExtent" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatMessages" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
code for methods in class "Rcpp_SpatMessages" was not checked for suspicious field assignments (recommended package 'codetools' not available?)
...
Quitting from lines 140-143 (GREENeR.Rmd) 
Error: processing vignette 'GREENeR.Rmd' failed with diagnostics:
OGR error
--- failed re-building ‘GREENeR.Rmd’

Adding 'codetools` to your Suggests should fix this. The reason why this doesn't show up on CRAN is because they test with all 'recommended' packages.

calfarog commented 2 years ago

Hi,

Thank you so much for your recommendation. We have added 'codetools' as Suggest library in the new version of GREENeR.

Regards,