search

calgo-lab / green-db

The monorepo that powers the GreenDB.
https://calgo-lab.github.io/green-db/
22 stars 2 forks source link

Change label ID strings #36

Closed maxjakob closed 2 years ago

maxjakob commented 2 years ago

and align them with Ecosia's.

maxjakob commented 2 years ago

still pending approval on the Ecosia side from another team, but this would be my suggestion for the IDs

se-jaeger commented 2 years ago

Ups didn't recognize this is directly a commit 😅

se-jaeger commented 2 years ago

@BigDatalex is currently working on preparing everything to use these IDs. If we agree on them, I would like to hand this over to him. 👍🏼

sleepypioneer commented 2 years ago

@se-jaeger @BigDatalex just checking the progress here?

se-jaeger commented 2 years ago

Almost done, see #39. Are you ready on your end? So if the branch is ready to merge, can we directly deploy it?

sleepypioneer commented 2 years ago

I will check but I assume so :)

sleepypioneer commented 2 years ago

@se-jaeger we are ready :rocket:

se-jaeger commented 2 years ago

@maxjakob and @sleepypioneer, @BigDatalex and I just merged the changes and deployed everything to prod. You will get the new IDs from from Monday. 👍🏼

Could you ping us from time to time if anything important in the labels JSON file changed? - Would be very helpful 😄

Closing this since its a subset of #39

sleepypioneer commented 2 years ago

Awesome thank you both! And absolutely we will let you know, we should probably think of some way to automate this if it is changing often (and not by us directly) but lets see :)