Closed BigDatalex closed 2 years ago
However, the rest looks good! Great to have tests now!
I commented some minor things. And some more in the following:
- I would prefer rename the test files. For example:
t-shirt_test.py
anddamen-pullover_test.py
this makes it clear which HTML it uses. Since they are in the subfolder zalando/Otto its clear where they belong to.- should we use another subfolder for the HTML file(s)?
- Could you implement a workflow that executes all tests when creating an PR. Examples are in
.github/workflows
What do you think?
Oh and I forgot to mention: Maybe just utils.py
instead of test_utils.py
?
Thanks for the review. Comments on your comments:
2. Currently we only have one test file for each merchant, so I think additional folders wouldn't improve the file/directory overview. But if we want to add more test_files and html files in the future, we should add another folder for the test-data.
We definitely should ;)
- Currently we only have one test file for each merchant, so I think additional folders wouldn't improve the file/directory overview. But if we want to add more test_files and html files in the future, we should add another folder for the test-data.
We definitely should ;)
Ok, so should I add then a subfolder "data" for each merchant?
Tests for otto and zalando from the old green-db-integration repo have been added and adjusted according to the new product class and other minor changes.