search

calgo-lab / green-db

The monorepo that powers the GreenDB.
https://calgo-lab.github.io/green-db/
22 stars 2 forks source link

Questions regarding Asos extractor #67

Closed se-jaeger closed 2 years ago

se-jaeger commented 2 years ago

Do we get only as sustainable tagged products from Asos? If yes, is it possible to add some code in the following snippet that uses CertificateType.UNKNOWN as label if we do not have any label mapping?

https://github.com/calgo-lab/green-db/blob/f255d8e6c5ff97dc555cf90e2f2bbec46b0a8092/extract/extract/extractors/asos.py#L160-L169

BigDatalex commented 2 years ago

Yes, all the products we are crawling are tagged as sustainable by Asos. We just had an offline discussion a while ago, where we decided to not use CertificateType.UNKNOWN for products where I have not identified a sensible sustainable phrasing/tagging. But if we want to change this now, we can just change the else return to return [CertificateType.UNKNOWN] instead of an empty list 😄

se-jaeger commented 2 years ago

I remember! Sorry!