search

calgo-lab / green-db

The monorepo that powers the GreenDB.
https://calgo-lab.github.io/green-db/
22 stars 2 forks source link

add otto EU_ENERGY_LABEL extraction for electronics #71

Closed BigDatalex closed 2 years ago

BigDatalex commented 2 years ago

This PR adds functionality to extract the (new) EU_ENERGY_LABEL for otto electronics categories. So far we have used just the private otto label energieefiziente Nutzung which was mapped to OTHER.

I implemented this in a seperate method and added also a separate _LABEL_MAPPING_ENERGY because the mapping relies just on one character, which identifies the level of the label e.g. C for EU_ENERGY_LABEL_C and this could lead to problems if the mapping would be combined with the original _LABEL_MAPPING.

BigDatalex commented 2 years ago

Ping @se-jaeger, I added the changes, which we discussed offline ;)

se-jaeger commented 2 years ago

@se-jaeger I would not remove this mapping, because there are electronics, which do not have the EU ENERGY LABEL und this would result now in a lot of UNKNOWN certificates, instead of OTHER.

That's a good point. Will revert it 👍🏼