search

calgo-lab / green-db

The monorepo that powers the GreenDB.
https://calgo-lab.github.io/green-db/
22 stars 2 forks source link

update taxonomy #83

Closed en-GB closed 2 years ago

en-GB commented 2 years ago

adds some new product categories like SNEAKERS and SOCKS

en-GB commented 2 years ago

obviously i cant test this yet so dont waste too much time on a review. but please point out any issues i can fix in the meantime.

BigDatalex commented 2 years ago

Does this PR adress the issue https://github.com/calgo-lab/green-db/issues/60?

en-GB commented 2 years ago

thanks for the thorough review. 👍

Does this PR adress the issue #60?

yes.

I would prefer for the Amazon Browse node ids to have the plain text of the browse node names, so that it is easy to check the mapping.

Ill look into it.

en-GB commented 2 years ago

as suggested i changed the amazon startjob to use names instead of ids. its also unified now and should make it very easy to add italian and spanish amazon, if thats ever needed.

BigDatalex commented 2 years ago

Hi @en-GB, I just had a look on the amazon categories most of them looked good 👍 I just did a few minor adjustments. In addition there were still some asos categories which were not aligned with GPC.

Since the cluster is running again, can you make a test run and check if any errors occur?

en-GB commented 2 years ago

👍 test is running

en-GB commented 2 years ago

Oh thats my bad. i messed with the enums. its a quick fix though.