Leader cards assignment in client not clear

caliandro-arturo / ingswAM2021-Caliandro-Converso-DAntini

Windows porting for the board game "Masters of Renaissance".

MIT License

2 stars 1 forks source link

Leader cards assignment in client not clear #7

Closed caliandro-arturo closed 3 years ago

caliandro-arturo commented 3 years ago

It's not clear the logical difference between

https://github.com/caliandro-arturo/ingswAM2021-Caliandro-Converso-DAntini/blob/6d3db4abf76b1ec9a8409b35e5382e4bd302cebb/client/src/main/java/it/polimi/ingsw/client/model/FullBoard.java#L12 and https://github.com/caliandro-arturo/ingswAM2021-Caliandro-Converso-DAntini/blob/6d3db4abf76b1ec9a8409b35e5382e4bd302cebb/client/src/main/java/it/polimi/ingsw/client/model/Board.java#L19 Are they duplicates?

DantiniMarco commented 3 years ago

redundancy is due to the previous version of the representation of the board against the full board. We previously decided to show all the leader cards (active and not) in the board . After that we decided to show only the active leader cards inside the board.

I never deleted the fullboard class for reason of reusability. Now it's superfluous

caliandro-arturo commented 3 years ago

Now is clear.