calibreapp / image-actions

A Github Action that automatically compresses JPEGs, PNGs and WebPs in Pull Requests.
https://calibreapp.com/blog/compress-images-in-prs
GNU General Public License v3.0
1.42k stars 67 forks source link

Feat: Support on-premise github enterprise #163

Closed suaaaaa closed 1 year ago

suaaaaa commented 1 year ago

What does this PR introduce?

Currently, only github.com API is supported, so it has been added to support github enterprise.

Related issues

Reviewers

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

benschwarz commented 1 year ago

@suaaaaa looks good to me, could you provide an example of how enterprise users can configure it? I’d like to ensure the readme includes the new functionality.

(Feel free to post the technical info, I can help with writing the documentation phrasing 😎)

suaaaaa commented 1 year ago

@suaaaaa looks good to me, could you provide an example of how enterprise users can configure it? I’d like to ensure the readme includes the new functionality.

(Feel free to post the technical info, I can help with writing the documentation phrasing 😎)

@benschwarz Thank you😃 GITHUB_API_URL is passed as the baseURL, so Enterprise users do not need to configure anything. What if the README image action offers added support for github enterprise?

Image Actions offers:

  • Fast, efficient and near-lossless compression
  • Best image compression algorithms available (mozjpeg and libvips)
  • Ease of customisation: use default settings or adapt to your needs
  • Running on demand or schedule
  • Support GitHub Enterprise
benschwarz commented 1 year ago

@suaaaaa Sounds good, could you add the bullet point as "Supports GitHub Enterprise" to README.md?

suaaaaa commented 1 year ago

@benschwarz Added and committed👍

thefoxis commented 1 year ago

if there's no need to configure anything for GitHub Enterprise customers, then the changes look good to me 😄 thank you, @suaaaaa!