calico / scBasset

Sequence-based Modeling of single-cell ATAC-seq using Convolutional Neural Networks.
Apache License 2.0
94 stars 12 forks source link

example,cell_embeddings #10

Closed lihaicheng7003 closed 2 years ago

lihaicheng7003 commented 2 years ago

examples/PBMC_multiome/evaluate.ipynb example: image my results: mark When I run cell embeding in the umap results are a little different, data: pbmc_ad.h5ad, pbmc_model.h5 (examples/download.ipynb downloaded) I guess it might be a problem with the parameters of sc.tl.umap(ad), but I have made many attempts and still can't change it. Can you provide a little advice? Thanks

hy395 commented 2 years ago

Hi @lihaicheng7003 ,

Unfortunately, I am not able to reproducible this particular issue. If you git pull a fresh scBasset repo, run "download.ipynb" and "evaluate.ipynb", would you be able to reproduce the issue?

For debugging, I don't see any issue in your code computing the umap. Could you verify the proj matrix? The matrix is directly taken from the downloaded model, so it should be the same. Here's the first 10 columns and 10 rows of the proj matrix:

image

Do you have the same proj matrix?

hy395 commented 2 years ago

Hi,

I verified that the MD5 is same. db34a4c5bb715204ff8b6a7ebb5e1121 Could you share the full script of your workflow?

lihaicheng7003 commented 2 years ago

Sorry, the matrix is the same, I had a mistake before, I said the matrix was different because I used my own trained model.

I found the reason, it was the scanpy version, before I used scanpy=1.7.2 and had different results, after updating to scanpy=1.9,1, the results were the same as yours. test1: scanpy=1.7.2 test2: scanpy=1.9,1 https://drive.google.com/drive/folders/15Kn0c6_bsZHlfgqzkIk4mbKcGfIU0p06?usp=sharing

Thank you for always replying

hy395 commented 2 years ago

Glad you figure out the solution. For your reference, I think this is an issue with the umap package: https://scanpy.discourse.group/t/umap-incorrectly-installed/663

lihaicheng7003 commented 2 years ago

gain a new knowledge