search

caligraf / ConfirmBeforeDelete

ConfirmBeforeDelete forked from version 0.3.5
GNU General Public License v3.0
1 stars 3 forks source link

Not confirming deletion of folders in the trash #19

Open Duncan-Moore opened 11 months ago

Duncan-Moore commented 11 months ago

ConfirmBeforeDelete does not confirm deletion of folders in the trash.

caligraf commented 11 months ago

How you do you delete the folders (context menu, del, edit menu ... )?

Duncan-Moore commented 11 months ago

It's the delete key normally. But there's also no confirmation message from the context menu. The edit menu does give a confirmation, but I almost never use this.

caligraf commented 10 months ago

I have created a new version 1.9.1 where I fixed not showed confirmation messages. Could you test it ? https://github.com/caligraf/ConfirmBeforeDelete/releases/download/1.9.1/ConfirmBeforeDelete.xpi

Duncan-Moore commented 10 months ago

Many thanks. Yes, it now gives a confirmation message when deleting a folder in the trash. A couple of observations: 1) when deleting a folder already in the trash the confirmation message is a bit misleading: "Do you want to move the folder to the trash ?" 2) the confirmation message typeface has changed from sans serif to serif. I don't know if that's by design or not. I prefer the sans serif, but that might just be me.

Duncan-Moore commented 10 months ago

I've noticed some odd behaviour with CBD 191: 1) To drag a message to trash, it must be selected before I drag it. If it wasn't selected beforehand, then the drag is ignored, or the message that /was/ selected is (wrongly) deleted. 2) Dragging a message to a folder within trash moves the message to trash instead, not the subfolder.

caligraf commented 10 months ago

I have done a new version 1.9.2, I have fixed the misleadingmessage and the drag of a message in a subfolder of the trash https://github.com/caligraf/ConfirmBeforeDelete/releases/download/1.9.2/ConfirmBeforeDelete.xpi

I will do another version to fix the drag in trash of a not selected message or a not selected folder.

Duncan-Moore commented 10 months ago

Yes, the misleading warning and the drag to a trash subfolder are working for me too in 1.9.2. Thanks.

caligraf commented 10 months ago

i fixed the drag and drop of a message in trash that is not selected in new version 1.9.3 https://github.com/caligraf/ConfirmBeforeDelete/releases/download/1.9.3/ConfirmBeforeDelete.xpi

Duncan-Moore commented 10 months ago

Yes, that working for me too with 1.9.3. Many thanks for all the effort you've put into this.