search

caligraf / ConfirmBeforeDelete

ConfirmBeforeDelete forked from version 0.3.5
GNU General Public License v3.0
1 stars 3 forks source link

Improved English messages #3

Closed Duncan-Moore closed 3 years ago

Duncan-Moore commented 5 years ago

I find the English wording of the configuration menu and delete confirmations somewhat quirky. I've attached what I think is better for en-US. This is relative to version 1.2.

confirmbeforedelete.zip

caligraf commented 3 years ago

I have integrated your suggestions in version 1.4 and 1.5

Duncan-Moore commented 3 years ago

Thanks for doing that.

I can't find the ConfirmBeforeDelete options.

They're not in the add-on description page, like other add-ons now have. And they're not on the Tools menu, where I think they used to be.

Does CBD still have configurable options?

I'm using Windows 10, TB 78.4.3 64-bit, CBD 1.5.2.

caligraf commented 3 years ago

Yes CBD is still have configurable options, it is in Tools > Add-On Preferences > ConfirmBeforeDelete. Do you have it ?

Duncan-Moore commented 3 years ago

Found it. I was looking under Tools on the hamburger button, not Tools on the "Mail Toolbar"!

When deleting a folder from the trash, it's not asking for confirmation, even though I've checked all of the 'confirm' options in the settings.

caligraf commented 3 years ago

I have done a fix, you can test the new version 1.5.3 https://github.com/caligraf/ConfirmBeforeDelete/releases/tag/1.5.3. It is not yet validated.

Duncan-Moore commented 3 years ago

Yes, that's working.

One other point I've noticed is that immediately after updating CBD, I get multiple confirmation boxes from CBD. I need to restart TB to get CBD working properly.

caligraf commented 3 years ago

in Thunderbird 68 add-ons were expected to be active after a restart, but now add-on can be activate at any time I will check how i can fix this

caligraf commented 3 years ago

I have opened issue #7 for work on the issue above