JDDateCountdownFlipView: Weird behavior when countdown reaches "0"

calimarkus / JDFlipNumberView

[iOS] Animated analog flip numbers like airport/train-station displays (Swift/SwiftUI ready)

MIT License

786 stars 138 forks source link

JDDateCountdownFlipView: Weird behavior when countdown reaches "0" #20

Closed friolz closed 11 years ago

friolz commented 11 years ago

There seems to be a problem with the countdown: When it gets reached (0 days, 0 hours, 0 minutes, 0 seconds) it restarts to count down with 1 minute left. After that it restarts with 1 hour left.

The correct behavior would be IMHO to freeze the countdown when it reaches "0".

calimarkus commented 11 years ago

@friolz erledigt!

friolz commented 11 years ago

Cool! Danke!

On 18.02.2013, at 15:05, Markus Emrich notifications@github.com wrote:

@friolz erledigt!

— Reply to this email directly or view it on GitHub.

rromanchuk commented 11 years ago

JDFlipNumberView should also "freeze" when it reaches zero. On 2.0.3 it resets

calimarkus commented 11 years ago

Well, that depends on the usecase. If you realize a clock, it should go from 0 to 60. You need to control this with the delegates / completion methods.