search

calimero-network / admin-dashboard

https://calimero-network.github.io/admin-dashboard/
8 stars 1 forks source link

feat: setup node url with query param #11

Closed frdomovic closed 3 weeks ago

frdomovic commented 3 weeks ago

feat: setup node url with query param

Summary:

The purpose of this PR is to start transitioning towards desktop application.

The user would have desktop application running and from dropdown would be able to open up the admin ui on browser. The backend of the application would provide the the URL where the admin ui is hosted and pass node_url as query parameter. The node_url can be fetched from the node service / or the calimero-desktop.

With this we would remove the need for Setup page. Right now it is still available but let me know what you think cc @xilosada @MatejVukosav

https://github.com/calimero-network/admin-dashboard/assets/93442516/f95d04c6-cc24-4916-b5ad-6c434b412c61

In the video the page redirects from / -> /auth -> /identity. And this is because we are just setting up the node_url but the user is already authenticated with his wallet and has client key in storage.

MatejVukosav commented 3 weeks ago

"With this we would remove the need for Setup page." <- not really. You still need setup page if port is not provided through url.

frdomovic commented 3 weeks ago

I want to keep this simple for this PR. Will add the popup wrapper we talked about (non closable - node not reachable error) in another PR

https://github.com/calimero-network/admin-dashboard/assets/93442516/30a3a385-18d9-4eba-809c-c65ca3efbfcb