search

calimero-project / calimero-core

Core library for KNX network access and management
Other
129 stars 65 forks source link

Wrap around of sequence number from 255 to 0 not considered? #18

Closed peti69 closed 9 years ago

peti69 commented 9 years ago

I think in KNXnetIPTunnel.java in line 182 it should be

if (seq == getSeqRcv() || ((seq + 1) & 0xFF) == getSeqRcv()) {

instead of

if (seq == getSeqRcv() || seq + 1 == getSeqRcv()) {

bmalinowsky commented 9 years ago

Yes, thank you!