search

calimero-project / calimero-core

Core library for KNX network access and management
Other
128 stars 65 forks source link

added support for "High" priority #60

Closed Redirion closed 6 years ago

Redirion commented 6 years ago

for example a project generated with ETS 5.6 may contain datapoint types with priority="High". I found this document(http://www.sti.uniurb.it/romanell/Domotica_e_Edifici_Intelligenti/110504-Lez10a-KNX-Datapoint%20Types%20v1.5.00%20AS.pdf), which assigns "0" to High priority, so using the existing type SYSTEM seems appropriate.

calimero-project commented 6 years ago

Thank you for pointing out the differing naming! High does not indicate system priority, but a lower priority. Actually I just looked into some ETS files, and there also exists "Alert" which shows as "Alarm" in ETS. So they stand for normal and urgent priority.

How did you notice this, during the xml import?

Redirion commented 6 years ago

an Exception was thrown, when I tried to load the XML(generated with import-ets-xml) into a DatapointMap: tuwien.auto.calimero.xml.KNXMLException: malformed attribute, invalid priority value (line 161, element datapoint stateBased=true name=GriesserObjekt mainNumber=219 dptID=219.001 priority=High) at tuwien.auto.calimero.datapoint.Datapoint.<init>(Datapoint.java:132) at tuwien.auto.calimero.datapoint.StateDP.<init>(StateDP.java:143) at tuwien.auto.calimero.datapoint.Datapoint.create(Datapoint.java:154) at tuwien.auto.calimero.datapoint.DatapointMap.load(DatapointMap.java:165)

calimero-project commented 6 years ago

There is an updated xsl in the import-ets-xml repo, which should take care of the different naming. Please note that by default, the latest .knxproj namespace version 14 is used now.