search

calimero-project / calimero-core

Core library for KNX network access and management
Other
128 stars 65 forks source link

New Translators for extended color DPTs #75

Closed lewie closed 4 years ago

lewie commented 5 years ago

Hello @bmalinowsky,

/*
 * 7.600  DPT_Absolute_Colour_Temperature [K] (TW) ------------>>> ETS knows, calimero doesn't
 * 232.600 DPT_Colour_RGB, values: 0 0 0...255 255 255, r g b->>> ETS knows, calimero too! 
 * 242.600 DPT_Colour_xyY
 * 243.600 DPT_Colour_Transition_xyY
 * 249.600 DPT_Brightness_Colour_Temperature_Transition ------>>> ETS knows, calimero doesn't
 * 250.600 DPT_Brightness_Colour_Temperature_Control --------->>> ETS knows, calimero doesn't
 * 251.600 DPT_Colour_RGBW ----------------------------------->>> ETS knows, calimero doesn't
 * 252.600 DPT_Relative_Control_RGBW
 * 253.600 DPT_Relative_Control_xyY
 * 254.600 DPT_Relative_Control_RGB
 */

There is several Hardware that uses these 2-byte, 3-byte and 6-byte color specific DTPs. Jung DALI Gateway TW Gira KNX DALI-Gateway MDT: LED Controller AKD, DaliControl IP Gateway DALI64, DaliControl Gateway DALI16/32

RGBW and other DTP information/definitions: https://www.mdt.de/download/MDT_THB_DaliControl_Gateway_03.pdf

What do you think, isn't it time to integrate the new color DTPs? Eventually for calimero 2.4 too?

Thank You!

bmalinowsky commented 5 years ago

That makes sense.

v2.4 is currently rc2, so additions are by default in master. But since new translators won't affect existing behavior, I can backport them into 2.4 if the translators have been tested before sufficiently. I can't test myself because I don't have HW with those DPTs.

I created a feature branch based on master here to track progress.

calimero-project commented 5 years ago

@lewie do you by any chance have access to HW which uses those dpts, and try them out?

lewie commented 5 years ago

First of all, best thanks for this patch!! It takes me some weeks, then I have suitable hardware and will test!

Have tested it so far with ETS, simulating telegrams sending to a prepared openHAB and calimero worked/identified as as expected.

calimero-project commented 4 years ago

All the color dpts are now implemented (some fine-tuning might be required).