Closed ghost closed 5 years ago
This is meant for initial review, I would be glad to incorporate your comments.
I missed the note of not force pushing pull request, will do better next time.
Yes, I think the static method approach works well. Some detail comments inline ...
When you're finished working on the PR, please tell me so I can merge it. I already ran the tests, apart from a few javadoc warnings it's all good.
I think I'm done with this for the moment. I will come up with a separate patch to use the statics in the Discoverer class. Many thanks for taking the time to look through the code.
You're welcome, thanks for the implementation!
The details can be found in KNX AN184 Page 4 and following, starting at paragraph 2.2.2.1.3 Search Request Parameter (SRP).