search

calintat / minimal

Personal blog theme powered by Hugo
https://themes.gohugo.io/minimal/
MIT License
402 stars 220 forks source link

theme's text is rendered wrong (centred) on Firefox #98

Open nuno-silva opened 4 years ago

nuno-silva commented 4 years ago

On Firefox, all blog contents appear centred instead of left-aligned.

I believe this is due to text-align: center; being applied to body here (which Firefox seems to apply to everything): https://github.com/calintat/minimal/blob/182410a422467bea5cc164910358d6c83414419f/static/css/main.css#L5-L10

I am not sure which of the renderings is correct, but I believe text should not be centred, since this also affects code blocks (see screenshot below).

Here's a few screenshots of one the example site's posts (https://themes.gohugo.io//theme/minimal/post/markdown-syntax/):

Firefox 73

firefox_73_themes gohugo io

Code blocks look specially awful :cry: (also firefox):

firefox_73_themes gohugo io_codeblocks

Chromium 80

chromium80_themes gohugo io__theme_minimal_post_markdown-syntax_

urlscan.io

https://urlscan.io/result/3467c0f9-8193-424b-9cad-b9ce70cb359f/compare urlscan.io screenshot

jaqmol commented 4 years ago

Same problem here. Removing the max-width from the main element seems to solves the problem.

jaqmol commented 4 years ago

Also: having the font-size connected to the height of the viewport is a bad decision for mobile! It's forced to scale badly like that on portrait proportions screens.

jimmysjolund commented 2 years ago

Any ideas for workaround? I don't get the suggestion to remove max-width to work. I really like the theme but need to get it to work on Firefox as well.