calipho-sib / feature-viewer

Library to visualize protein sequence features in javascript using D3 - From SIB CALIPHO group; neXtProt project
http://calipho-sib.github.io/feature-viewer/examples/
Other
110 stars 31 forks source link

Conflict with bootstrap 4 #30

Open Takkoona opened 6 years ago

Takkoona commented 6 years ago

Hi,

I started my project with bootstrap 4 and didn't find feature-viewer until the late stage of development. The problem is my styling framework conflicts with feature-viewer's, which is because it's depended on bootstrap 3. The functional part remains unaffected but just the look of it is not so pleasant. I can use 'scoped style' to deal with the conflict but this technique is not supported by major browsers except Firefox 21+.

I saw some solutions that suggest using iframe or adding class name before css selector. It's not very necessary to use iframe in my case. Class name sounds like a way to go but cannot do too much my end. It would be great if the conflict can be solved.

And lastly I need to add an 'f' before the object id to select the element. It's been great using feature-viewer. It's highly programmable and I really enjoy it.

MatSchaeff commented 4 years ago

Hello Takkoona, Sorry for the late reply, do you still have this conflict of style? I tried to reproduce it in this fiddle by importing bootstrap 4 css, but I cannot see the problem : https://jsfiddle.net/3joge19v/1/

However I agree that bootstrap 3 is quite big for this viewer and shouldn't be required, or at least not all of it. Thank you for your appreciation!