calipho-sib / feature-viewer

Library to visualize protein sequence features in javascript using D3 - From SIB CALIPHO group; neXtProt project
http://calipho-sib.github.io/feature-viewer/examples/
Other
110 stars 31 forks source link

Has the "+ Add Variants" button made a comeback in version > 1.3.0? #80

Open lianos opened 10 months ago

lianos commented 10 months ago

Hi,

I'm not a javascript guru by any means, so I'm sorry for the naive question, but I've been working creating an wrapping this into an R/htmlwidget package that can be used from within R/shiny.

I've appreciated that the "+ Add Variants" button was removed by default, as noted in this issue in the 1.3.0 branch/release.

I'm not sure how actively this library is maintained, but I've noticed that there is a release/1.5.0 branch (as well as a 1.4.0), so I figured I might as well go from there, but it looks like the "+ Add Variants" button has made a come back.

It doesn't seem like there is an option to switch it off, but it seems like this might be something that could naturally be passed as some boolean flag in the options parameter of the createFeature constructor.

I'm curious if I'm missed something, or no?

Thanks!