Fixes the order of the displayed courses according to their config.

mwehr commented 11 months ago

Hi,

This fixes the order of the displayed courses according to their configuration.

Best regards, Mario

danielneis commented 9 months ago

hello, It would be better if you sort the records in the get_records_select call

peta3000 commented 2 months ago

Hii @danielneis first of all, many thanks for your efforts in developing and maintaining this plugin!

Albeit its nice design and layout the Block plugin is HIGHLY MISSING a functionality to sort/order selected courses, like:

to either sort the selected courses oneself (via CSS-Selectors like in this PR from @mwehr

or

like in the given PR, to have the selected courses being displayed in a successive order (which one can also adjust further via custom CSS code)

As a site-admin, I would install this plugin much more often, if it had this missing functionality.

Dear @danielneis I tried out the patch from @mwehr on a Moodle 4.1 instance and it actually worked fine, I even did not get any debug-messages since the branch did not receive any adjustments to 4.1. So it actually works.

And dear @mwehr do you think it might be possible to implement the same functionality by using the safe_records_select call, as @danielneis suggested?

The would really profit from an added sorting functionality!!! 🙏

Cheers

p

mwehr commented 2 months ago

Hi @peta3000,

See #12 for SQL verison.

call-learning / moodle-block_featured_courses

Fixes the order of the displayed courses according to their config. #7