search

callahantiff / OMOP2OBO

OMOP2OBO: A Python Library for mapping OMOP standardized clinical terminologies to Open Biomedical Ontologies
http://tiffanycallahan.com/OMOP2OBO_Dashboard
MIT License
80 stars 12 forks source link

Add vanity CLI #56

Open cthoyt opened 3 years ago

cthoyt commented 3 years ago

If the main.py were included in the source code hierarchy, the python entrypoints in setuptools could be used ot make a vanity cli called omop2obo along with installation of the code. This would make it much more extensible for others since they wouldn't have to know where the code itself was. Would you be willing to accept a PR for this?

callahantiff commented 3 years ago

Hey @cthoyt! The functionality you are describing sounds like a great. Thanks for offering to do this, I'd be happy to review a PR 😄

joeflack4 commented 2 years ago

I have some experience with CLIs, as well as packaging and releasing stuff on PyPi. I don't know how much extra bandwidth I have, but this is something I could possibly help with.

@cthoyt What is a vanity CLI? Is that just a figure of speech, or a particular type of CLI?

cthoyt commented 2 years ago

This is when you use Python entrypoints to make a nice CLI command available in the shell like obo2omop - this is not a standard phrase but I think it's appropriate since it wraps what would otherwise be python -m obo2omop. Please note I already sent a PR that solves this issue, linked just above your comment (or here #57)

more info on how I think about this on my blog: https://cthoyt.com/2020/06/11/click.html

joeflack4 commented 2 years ago

Ah ok, that's pretty cool. I'll give that a read.