search

callahantiff / PheKnowLator

PheKnowLator: Heterogeneous Biomedical Knowledge Graphs and Benchmarks Constructed Under Alternative Semantic Models
https://github.com/callahantiff/PheKnowLator/wiki
Apache License 2.0
160 stars 29 forks source link

TODO: Add licenses for public data? #14

Closed callahantiff closed 5 years ago

callahantiff commented 5 years ago

TODO: Is it enough to cite the data sources used in the knowledge graph on the [Wiki]() or do I need to additional information like the license (if available)?

@LEHunter or @bill-baumgartner - what are your thoughts on this?

callahantiff commented 5 years ago
callahantiff commented 5 years ago

@bill-baumgartner @LEHunter -

Do you think this is good for documentation?

LEHunter commented 5 years ago

Yes, nice. You might include a brief statement about the rationale for the choices at the top of each version

On Sep 17, 2019, at 11:00 PM, Tiffany J. Callahan notifications@github.com wrote:

@bill-baumgartner @LEHunter -

Do you think this is good for documentation?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

bill-baumgartner commented 5 years ago

One minor fix: Under the Releases heading, the text for the release 2.0.0 link says v1.0.0

callahantiff commented 5 years ago

Yes, nice. You might include a brief statement about the rationale for the choices at the top of each version … On Sep 17, 2019, at 11:00 PM, Tiffany J. Callahan @.***> wrote: @bill-baumgartner @LEHunter - Do you think this is good for documentation? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

@LEHunter - Great suggestion!

callahantiff commented 5 years ago

Thanks for your help with this issue. I have fixed the typo and added the suggested text. Please re-open if you feel additional information is needed.