callahantiff / PheKnowLator

PheKnowLator: Heterogeneous Biomedical Knowledge Graphs and Benchmarks Constructed Under Alternative Semantic Models
https://github.com/callahantiff/PheKnowLator/wiki
Apache License 2.0
165 stars 29 forks source link

HELP - Verifying Wiki Content #33

Closed callahantiff closed 4 years ago

callahantiff commented 4 years ago

Thanks so much for being willing to help with this @jwyrwa!

I am hoping that you would be willing to proof each of the following Wiki pages listed below to verify I have removed all spelling/grammar errors and to make sure that the content makes sense to you (i.e. if you were trying to use this repo would would know what to do):

jwyrwa commented 4 years ago

Home

callahantiff commented 4 years ago

Home

  • [x] 'Data for this release can be downloaded here' - This link doesn't scroll like I think you were expecting. It looks like the URL might need to be this
  • [x] 'We presented this work (poster) at the 15th Annual Rocky Mountain Bioinformatics Conference held December 6-8th in Snowmass, Colorado.' - Why is the poster file titled 'Rocky2017' but the link to the conference is for 2018?

Good catch! I have updated both URLs.

jwyrwa commented 4 years ago

KG Construction

callahantiff commented 4 years ago

KG Construction

  • [x] "The OWLTools command line tool is used to download all ontologies. " - dead link
  • [x] "This tool is useful because it ensures that all ontologies imported by the ontology being downloaded are also downloaded and merged together." -- Would it be accurate saying something like this instead to be more clear? "This tool is useful because it ensures that all secondary ontologies imported by the primary ontology are also downloaded and merged together.
  • [x] "These steps are important and may require consulting with an expert." - what kinda expert?
  • [x] You bounce between using "EXAMPLE" and "Example" (underlined). Consider being consistent.
  • Wiki Page: Dependencies
  • [x] The beginning of the 'Dependencies' page as does the previous page says 'preparation of three documents' and then lists 8 things? What are the three documents?
  • [x] "Edge Type: An edge label (node1-node2) should match Data Sources in the ontology, class edge, and non-class edge input files." - class edge link is broken
  • [x] "Source labels: Three ; separated items (e.g.:;GO;GO): character to split existing labels (e.g. : in GO:1283834) and label for subject and object nodes. If the existing label is correct, type ;;." - The first sentence isn't a complete sentence. I don't understand the '): character to split existing labels" segment. Should there be a comma and a space in between the parenthesis and colon '), :'?
  • [x] "https://reactome.org/content/detail/" - broken link
  • [x] [Construction Approach](Construction Approach) - this links back to the KG Construction page, making a loop. I'm confused.
  • [x] What's a "UUID"?
  • [x] "An example list can be found here." - dead link

@jwyrwa - very helpful, thank you!! I have updated everything to reflect what you commented on. The following two points you made:

Are actually OK and functioning fine.

For the point about the source labels, I tried to improve the language and changed it to the following:

`Source labels: Three ;-separated items (e.g.:;GO;GO). The first item (i.e. ':') is a character that is used to split existing labels (e.g. : in GO:1283834), such that all characters that occur before that label are replaced by the content provided after the first and second ';' (i.e. 'GO' and 'GO'). If the existing label is correct, type ;;.

Does that make more sense?

jwyrwa commented 4 years ago

Yup.

jwyrwa commented 4 years ago

Should OWL always be all caps? 'owl' is used in some cases.

callahantiff commented 4 years ago

Should OWL always be all caps? 'owl' is used in some cases.

It should be all caps. Are the lowercase uses in code blocks? If so, that's OK.

jwyrwa commented 4 years ago

OWL NETS 2.0

callahantiff commented 4 years ago

OWL NETS 2.0

  • [x] I tried putting a dash in the title of the page, but it won't stick :(

  • If you are talking about the header at the very top of the WIki page, then yeah that's something we can't change. Thanks for trying though!

  • [x] "A json file or dict() mapping an owl:Class to an instance of the owl:class (primarily used for PheKnowLator, for example:" - should both be 'Class' or 'class'? Is there a missing parenthesis?

Ahh, this part actually needs to be removed to reflect the refactoring I did to simplify this method. I have updated that section now. Thanks for catching that!

jwyrwa commented 4 years ago

Reasoner Evaluation

jwyrwa commented 4 years ago

v2.0.0

callahantiff commented 4 years ago

v2.0.0

  • [x] "Added Data_Preparation.ipynb Jupyter Notebook to aid in creation of mapping, filtering, and labeling datasets Added Ontology_Cleaning.ipynb Jupyter Notebook to aid in creation of mapping, filtering, and labeling datasets" - these both do the same thing? Could I just collapse it into "Added Data_Preparation.ipynb and Ontology_Cleaning.ipynb Jupyter Notebooks to aid in creation of mapping, filtering, and labeling datasets"

Fixed, the text should not have been the same. Thanks for catching that!

  • [ ] Ontologies - all of the links are broken (404 error) Fixed!

  • [x] "Relations and Inverse Relations ➞ INVERSE_RELATIONS.txt Relations and Labels ➞ RELATIONS_LABELS.txt" - 404 errors Fixed!

  • [x] "STANDARD RELATIONS", "Edge Lists", "Node Metadata" - all of the links in this table take me to a 'Create new page' Yes, sorry, these links will be down until results are finished.

  • [x] "Generated Output", "Generated Output" - are these (almost) exactly the same? All the same links in both sections are having the same issue I described above. Thoughts on condensing into one 'Generated Output' Section that has something like "Common Output" and then having "Unique to Subclass-Based Construction" and "Unique to Instance-Based Construction"? It'll cut down on redundancies and make it easier to maintain. Yes, sorry, these links will be down until results are finished. They will point to different things.

jwyrwa commented 4 years ago

v2 Data Sources

callahantiff commented 4 years ago

Thank you so much @jwyrwa !! This was incredibly helpful I have made all suggested changes and will now close this issue!