HELP - Verifying README Content - Githubissues

callahantiff / PheKnowLator

PheKnowLator: Heterogeneous Biomedical Knowledge Graphs and Benchmarks Constructed Under Alternative Semantic Models

https://github.com/callahantiff/PheKnowLator/wiki

Apache License 2.0

157 stars 29 forks source link

HELP - Verifying README Content #36

Closed callahantiff closed 4 years ago

callahantiff commented 4 years ago

Thanks so much for being willing to help with this too @jwyrwa! 🙏

I am hoping that you can proof each of the following README pages (listed below) to verify it's free of spelling/grammar errors and to make sure that the content makes sense (i.e. if you were trying to use this repo you this content would be helpful):

jwyrwa commented 4 years ago

[x] "The PyPi package will not be completely functional until this release is finalized." - should this be PyPI?
[x] "Please see the Data_Preparation.ipynb Jupyter Notebook for detailed examples of the steps used to build the v2.0.0 knowledge graph." - this links to v1.0.0 KG
[x] "please see the knowledge graph README for more information" - 404 link
[x] "resources/Master_Edge_List_Dict.json" - 404
[x] "resources/owl_decoding/OWL_NETS_Property_Types.txt" - 404
[x] "Command Line ➞ Main.py" - 404
[x] "Finally, pkt_kg can be run using a Docker instance. <>." 😄

jwyrwa commented 4 years ago

construction_approach

[x] "A pickled dictionary where the keys are node identifiers (non-ontology node data) and the values are lists of ontology class identifiers to subclass has been added to the ./resources/construction_approach/ directory." - either I'm reading this wrong or there's word(s) missing after "ontology class identifiers"

jwyrwa commented 4 years ago

edge_data README

[x] "edge_source_list.txt", "resources/edge_data/ chemical-disease_CTD_chemicals_diseases.tsv chemical-gene_CTD_chem_gene_ixns.tsv chemical-phenotype_CTD_chemicals_diseases.tsv chemical-protein_CTD_chem_gene_ixns.tsv" - are these all meant to be links?

jwyrwa commented 4 years ago

embeddings README

[x] "Jupyter Notebook: Main.ipynb" - 404
[x] "an implementation of the original algorithm in C ++, with some improvements to speed up initialize the hierarchical softmax tree that was developed by Anton Tsitsulin." - this sentence makes sense up until "up".
[x] "For the Headers, the sub-directory called Boost at the top-level of the walking-rdf-and-owl-master directory." - missing word(s)

jwyrwa commented 4 years ago

knowledge_graphs README

nada, looks great!

jwyrwa commented 4 years ago

node_data README 👍

jwyrwa commented 4 years ago

Done!

callahantiff commented 4 years ago

Thanks so much @jwyrwa for all of your edits, I really appreciate it!!!