search

callbackwomen / callback-women-rails

App will help women who are programming speakers better connect with programming conferences' CFPs.
http://callbackwomen.com
2 stars 6 forks source link

A user can be created and logged-in using Twitter Auth #3

Closed johana-star closed 10 years ago

johana-star commented 10 years ago

The OmniAuth Railscast was key to getting this done.

johana-star commented 10 years ago

Yo! @cczona it's distinctly not much to look at, but I have user creation/authorization through Twitter down. This is the lynchpin for the rest of the app… Not much to look at but solid groundwork.

I didn't write tests for this… :-/ It's fairly boilerplate but I still would like proof that it works if/when it breaks because of future change.

sigmavirus24 commented 10 years ago

The code looks right to me. I didn't go as far as creating a Twitter App to get a key/secret pair and test with that.

johana-star commented 10 years ago

I got some unit tests on the model, I think it moght also be useful to test the SessionsController#create and #destroy, however this may be overkill.

sigmavirus24 commented 10 years ago

That seems reasonable to me.

johana-star commented 10 years ago

This should be ready to roll.

johana-star commented 10 years ago

This blog post was helpful.