search

callerc1 / shipit-npm

Npm tasks for shipit.
MIT License
21 stars 12 forks source link

Change to fetched if running locally #1

Closed timkelty closed 9 years ago

timkelty commented 9 years ago

If you were running it locally, you'd want to do it on fetched, yes? So everything gets copied to the server.

callerc1 commented 9 years ago

Yup this makes sense thanks for spotting that, tho pr is falling over on initial checkout. Cannot read property 'npm' of undefined

timkelty commented 9 years ago

Ah, right. It seems shipit.initConfig hasn't been called yet at this point, so we can't access those properties.

@neoziro, any ideas here? Basically, I think we want to access shipit config properties outside of a task definition.

gregberge commented 9 years ago

@timkelty do it in the task, it's easy.

gregberge commented 9 years ago

@timkelty it's just about architecture and implementation of your module, but effectively you can't access to the config before shipit has registered its config.

callerc1 commented 9 years ago

@timkelty @neoziro i have updated the shipit-npm package just now which gets around this issue. specifically https://github.com/callerc1/shipit-npm/commit/82f4bf83a600c7fdcc85a0370eb3a030674e74a1

timkelty commented 9 years ago

@callerc1 are you running through Grunt? Your fix works for me in Grunt but not through shipit cli

callerc1 commented 9 years ago

Nope just using shipit cli.