search

callerc1 / shipit-npm

Npm tasks for shipit.
MIT License
21 stars 12 forks source link

Ensure npm:install be a blocking task. #2

Closed timkelty closed 9 years ago

timkelty commented 9 years ago

shipit-utils.registerTask defaults to an async task if possible. Here we want to make sure to wait for completion before moving on.

callerc1 commented 9 years ago

This looks sweet. I'll take a proper look tomorrow. Could be what was causing your shipit-cli issues.

timkelty commented 9 years ago

Sounds good.

callerc1 commented 9 years ago

This is cool, and the update to shipit-utils fixes the async/blocking issues. Tho is it not the child task npm:install that needs to be registered as blocking?

callerc1 commented 9 years ago

Essentially if i set blocking only on the parent npm task (like in the pr) then it doesn't block.

callerc1 commented 9 years ago

Have merged but set async false on npm:install task instead.

timkelty commented 9 years ago

Sounds good. By the way, utils.registerTask is now blocking by default, so you can lose that last argument if you want.

Sorry for the waffling!

callerc1 commented 9 years ago

Perfect think that is a good move. Thanks for the update.