Shippit waits for npm to finish install locally, which is good, how did you do that ?

callerc1 / shipit-npm

Npm tasks for shipit.

MIT License

21 stars 13 forks source link

Shippit waits for npm to finish install locally, which is good, how did you do that ? #6

Closed tim-field closed 9 years ago

tim-field commented 9 years ago

Not a bug, but a question :) I'm trying to fire bower and composer tasks locally on deploy but these always complete after the deploy has happened.

How do you get shippit to wait for npm install to finish before it deploys. The obvous answer would be a blocking task, but looking at the code it doesn't seem you are doing this ?

callerc1 commented 9 years ago

@timbofield your correct it is in fact blocking by default (https://github.com/shipitjs/shipit-utils/commit/7eed4ec30ca49a8e4e7feea706f67a13b8e1a7a1). The blocking part is handled in the shipit-utils dependancy. see this for more details: https://github.com/callerc1/shipit-npm/pull/2

Hope that helps.

tim-field commented 9 years ago

Thanks!