callerc1 / shipit-npm

Npm tasks for shipit.
MIT License
21 stars 12 forks source link

Removing preinstall, adding triggerEvent option. #9

Closed timkelty closed 9 years ago

timkelty commented 9 years ago

This is a fix for #8.

Rather than bothering with an empty preinstall task, I've removed it and instead added a triggerEvent option.

It still defaults to either updated or fetched, but also gives the user the option to totally disable it (with false). Or trigger it on another event. This gives complete control of the event flow without having to trigger things on preinstall.

callerc1 commented 9 years ago

Hi @timkelty just checking this out now. looks pretty badass! way better than my preinstall task. Hopefully ill get a chance to merge either today or tomorrow. Thanks!

timkelty commented 9 years ago

Sounds great, thanks.