Closed brynpickering closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e2bfb1a
) 95.66% compared to head (67f6919
) 95.70%.
Quite considerable memory footprint created by having dual tracking activated in pyomo:
without dual tracking:
with dual tracking:
Heap size peak changes from 204MB to 370MB for this example case (urban scale, 2 months).
Have updated the implementation to be deactivated by default and to allow user activatation. It also deactivates automatically if trying to run using CBC solver.
I wouldn't do anything special for dealing with duals in MILP models. The default in Pyomo is just to return None instead of a value, so I think that's fine?
My implementation of shadow prices as a class attribute of the BackendModel is in the directio of how I'd imagine implementing #510.
Will update changelog and docs later this week
Fixes issue(s) #283
Summary of changes in this pull request:
Example:
TODO:
Reviewer checklist: