Closed brynpickering closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
fd2917b
) 95.76% compared to head (39861c3
) 95.76%.:exclamation: Current head 39861c3 differs from pull request most recent head eb953af. Consider uploading reports for the commit eb953af to get more accurate results
@irm-codebase and @sjpfenninger, ready for review.
@irm-codebase, you can view the documentation with the PR changes by selecting "Details" of the readthedocs CI check (once it has a green tick mark next to it):
Most things look great so far!
I only found one funky detail in the schema:
Most things look great so far! I only found one funky detail in the schema:
Yeah, this is an issue with the upstream dependency. It can't handle "OneOf"/"AnyOf"/"AllOf" schema elements. Another reason perhaps to have a different place to describe parameters.
Most things look great so far! I only found one funky detail in the schema:
Yeah, this is an issue with the upstream dependency. It can't handle "OneOf"/"AnyOf"/"AllOf" schema elements. Another reason perhaps to have a different place to describe parameters.
In that case I'd recommend to add parameters to the math section (as a table, maybe?). To be honest, I am struggling a bit when translating an older model (the Italy one) to test the pathways because of this, since not all cases are listed.
Fixes #555
Changes made in this Pull Request
Reviewer checklist: